-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Definition of environment and implementation of first plugins #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalepee
requested changes
Aug 25, 2022
- `--config` : takes a folder that will be used as config folder instead of the system one - `--deploy` : takes a yaml file that will be used as deployment file - `--platform` : takes a yaml file that will be used as platform file
Environment contains a Configuration and a WorkingDir Updated most calls to use the correct elements Now dry_run is part of the Environment Override of config and WorkingDir is available via environment variables
use `click.Context.find_object` to get the environment and extracting the working dir from there instead
Can be added with command `babylon config plugin add plugins/dev_tools` in Babylon folder
removed check for overridden before operations on config
neomatamune
force-pushed
the
configuration_override
branch
from
August 26, 2022 07:43
6e3f7dc
to
8164be4
Compare
lalepee
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the definition of an
Environment
class that contains aConfiguration
and aWorkingDir
(new name forSolution
)Adds an override of
Configuration
andWorkingDir
via environment variables allowing easier scripting of babylon commandsMoved group
babylon dev
to plugindev_tools
making the addition of those commands optional, and only babylon or plugins developers should activate it.Moved group of commands
v0
to a pluginv0
allowing to keep the example of connections to the multiple microsoft services, but without adding those commands directly in babylon (plugin should be removed between 1.0.0 and 2.0.0)Overall cleaning of the documentation