Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: Migrate the correct amount of Core-1 funds #959

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

Reecepbcups
Copy link
Contributor

No description provided.

@Reecepbcups
Copy link
Contributor Author

Reecepbcups commented Feb 5, 2024

hardcode breaks the v19 unit test (not generalixed to match expected) but does not matter since it wont be doing again

@Reecepbcups Reecepbcups merged commit fc06bf4 into release/v19 Feb 5, 2024
20 of 24 checks passed
@kopeboy
Copy link

kopeboy commented Feb 6, 2024

I see the hardcoded number is different than the one in the comment (which has one more digit, 5, at the end): which one is right? @joelsmith-2019 did you review it?

@Reecepbcups
Copy link
Contributor Author

@kopeboy the 5 is supposed to be at the end yes. miscopy on my end so only 530k got transferred instead of the 5.3m

@joelsmith-2019 joelsmith-2019 deleted the reece/v19-fix-migration branch February 14, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants