Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOODS dependency not referenced #107

Closed
ebirn opened this issue Mar 5, 2019 · 2 comments
Closed

MOODS dependency not referenced #107

ebirn opened this issue Mar 5, 2019 · 2 comments
Assignees

Comments

@ebirn
Copy link

ebirn commented Mar 5, 2019

MOODS module is used, but no reference in requirements.txt or setup.py/setup.cfg

from MOODS import tools, parsers

only reference seen in .travis.yml, call to rgt-motifanalysis script fails

login0 [~]> rgt-motifanalysis 
Traceback (most recent call last):
  File "/software/RGT/0.11.7-foss-2018b-Python-2.7.15/bin/rgt-motifanalysis", line 11, in <module>
    load_entry_point('RGT==0.11.7', 'console_scripts', 'rgt-motifanalysis')()
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 476, in load_entry_point
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 2700, in load_entry_point
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 2318, in load
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 2324, in resolve
  File "/software/RGT/0.11.7-foss-2018b-Python-2.7.15/lib/python2.7/site-packages/rgt/motifanalysis/Main.py", line 16, in <module>
    import Match
  File "/software/RGT/0.11.7-foss-2018b-Python-2.7.15/lib/python2.7/site-packages/rgt/motifanalysis/Match.py", line 22, in <module>
    from .Motif import Motif, ThresholdTable
  File "/software/RGT/0.11.7-foss-2018b-Python-2.7.15/lib/python2.7/site-packages/rgt/motifanalysis/Motif.py", line 13, in <module>
    from MOODS import tools, parsers
ImportError: No module named MOODS

Best,
Erich

@fabio-t
Copy link
Member

fabio-t commented Mar 5, 2019

This should actually be fixed in setup.py, yes. It's not available on pypi yet (I've asked the author a long time ago), and on our instructions it's stated you should install it if you wish to use motif analysis (which is also what you see in the travis config file):

pip install https://github.com/fabioticconi/MOODS/tarball/pypi-ready

We'll see if we can put a fix in for the next release.

@fabio-t fabio-t self-assigned this Mar 5, 2019
@fabio-t
Copy link
Member

fabio-t commented Mar 12, 2019

Fixed via 71e3f4f

@fabio-t fabio-t closed this as completed Mar 12, 2019
@fabio-t fabio-t mentioned this issue Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants