Add salt when salt on Countly server is set #470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"all requests would be checked for the validity" what kind of validity are you thinking of? If there would be any mistakes or errors in the params, it would not protect against those. checksums don't add any additional security for websites since anyone can check the salt value and still fake requests with it. |
|
Hi @leewenbil we added this feature at new release (24.4.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know that If salt on Countly server is set, all requests would be checked for the validity of &checksum field before being processed. So need to set exactly the same salt on the on the SDK side, then salt to be used for calculating checksum of request data, which will be sent with each request using &checksum field.