Question Level Student Statistics Table (Part 2: Attempt Count)

[bivanalhar]

Background

As a continuation from the previous PR #7077 which implements the Marks per Question table, this PR focuses on implementing the table for Attempt Count.

This PR is related with the issue #4567

More Details

While Marks per Question table enlists the grades obtained by each student for each questions in an assessment, this table serves the number of attempts that each student has done for each questions. Practically, we want to see how many attempts student has tried for each question, and whether or not student finally is successful in attempting the question (by getting CORRECT verdict from our system)

This feature is aimed mainly for Autogradable questions (MCQ, MRQ, Programming, and some Text Response Question), in which student usually tries to submit the answer multiple times to see if their answers meet the criteria defined by the problem setter through test-cases (in case of Programming and Text Response) or are correct (for MCQ, MRQ). For other question types, we still display the number of attempts given (for the sake of consistency), however we give different colors for this kind of questions, to tell user that the question is not automatically graded by the system.

Table

Slightly different than the Marks per Question Table, here are the explanation for each cell's color box:

• Green indicates that the attempt is successful (either the code gives pass verdict to 100% of the test cases or the answers are completely correct)
• Red indicates that the attempt is unsuccessful (either the code gives pass verdict to partial or none of the test cases or the answers are not completely correct)
• Gray indicates that the question is not autograded, and hence cannot tell if the attempt is successful or not by the system.

Performance Improvement

Within this PR, we also recognised that while going towards the Assessment Statistics Summary (table and chart), the waiting time is quite long (around 3-5 seconds). This problem was not yet visited in the previous PR, but then the problem exacerbated when we found that accessing this page while having the Attempt Count Table took almost 1 minute.

Upon investigation, we found out that the bottleneck is due to the performance of doing Preloading in Rails, which basically loads all the information from a specific model, including all the attributes that we don't use for displaying the statistics table.

For this reason, we decided to move out all the implementation for getting all Answer information (attempt count, marks in each question, etc.) into using SQL. This migration dramatically decreases the total rendering time into only around 2-3 seconds.

To-Do Next

• Activate rendering of the Past Answer view when user clicks on the marks box or attempt count box, depending on which table user's navigating from (if from marks per question table, we only display current answer. If from attempt counts question, we show all the past answers, including the current answer) (Show Answer Details in Assessment Statistics Page (Part 1: Last Graded Answer (MCQ, MRQ, Text Response, File Upload)) #7130 and Show Answer Details in Assessment Statistics Page (Part 2: Last Graded Answer (Forum Post Response, Programming)) #7131)
• Design the API to fetch the past answers and also API to fetch the complete current answer (will consider to combine both into one single API if possible) (Show Answer Details in Assessment Statistics Page (Part 1: Last Graded Answer (MCQ, MRQ, Text Response, File Upload)) #7130 and Show Answer Details in Assessment Statistics Page (Part 2: Last Graded Answer (Forum Post Response, Programming)) #7131)

Future Improvement

• Modularise the API for assessment statistics so that each component has their own API call for fetching data from DB (in the vision that if the tab was first visited after quite long period of time, we can prompt the API to be called again, without needing to reload the whole table)

[ekowidianto]

@bivanalhar Can help to rebase this and all subsequent related PRs?

[bivanalhar]

@bivanalhar Can help to rebase this and all subsequent related PRs?

@ekowidianto I have rebased this PR.. as for the subsequent related PR, I think better if the review of this PR is finished first, since if there is a change in this PR, I need to rebase it again later after you finished reviewing.

[ekowidianto]

• Add Legends to show what the colors mean for both Marks Per Question and Attempt Count Pages. As a user, I have no idea what green means when I see it.
• I still see a lot of N+1 and it took >10 seconds for the page to load.

[bivanalhar]

• Add Legends to show what the colors mean for both Marks Per Question and Attempt Count Pages. As a user, I have no idea what green means when I see it.

Legends are added. I thought the term lowerGrade and higherGrade is sufficient to explain, but nevertheless I have put more explanation for those terms

• I still see a lot of N+1 and it took >10 seconds for the page to load.

Apologies for the insight. I think this also got lost in the midst of rebasing, since I remembered previously I utilised the hash I have made for groups. I have reverted it back to using hash to retrieve groups name

[benleong]

" it took >10 seconds for the page to load."

When you see this during testing, you should know something is wrong. You need to do better.

[ekowidianto]

Legends are added. I thought the term lowerGrade and higherGrade is sufficient to explain, but nevertheless I have put more explanation for those terms

What I mean is as a teacher (user) who goes to the page and view the colors, they would not know what the colors mean. I mentioned as a "user", not "developer" and I also said "legend" not "comments".

[bivanalhar]

Legends are added. I thought the term lowerGrade and higherGrade is sufficient to explain, but nevertheless I have put more explanation for those terms

What I mean is as a teacher (user) who goes to the page and view the colors, they would not know what the colors mean. I mentioned as a "user", not "developer" and I also said "legend" not "comments".

apologies for the misunderstanding. I have created the reusable component so that user can add in Legends to the Table as well, and I have applied it to both Attempt Count and Marks per Question

[bivanalhar]

" it took >10 seconds for the page to load."

When you see this during testing, you should know something is wrong. You need to do better.

Understand and well-noted, Prof. Actually I didn't catch this long-timing issue when I did the testing but it's because I used the course with not that many students inside (I used CS2109 instead of CS1010). This is entirely the mistake from my part and I promise I will use the course with most number of data in the future