-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Answer Details in Assessment Statistics Page (Part 1: Last Graded Answer (MCQ, MRQ, Text Response, File Upload)) #7130
Open
bivanalhar
wants to merge
12
commits into
master
Choose a base branch
from
bivan/teacher-stats-past-answer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc5ec90
to
288e29c
Compare
2 tasks
This was referenced Mar 6, 2024
22881ce
to
d304444
Compare
288e29c
to
5829efd
Compare
0313c8d
to
a6cf1cd
Compare
Base automatically changed from
bivan/teacher-statistics-attempt-count
to
master
April 4, 2024 01:46
8aa52c6
to
cd2abee
Compare
cd2abee
to
f6a881f
Compare
- combine ancestor info and marks per question into main statistics - remove all unnecessary controllers
- make the grade and attempt count box clickable
- each grade and attempt count cell is clickable - after clicking, the box containing question will appear
- fetch question and answer details in one API - use Accordion for question to allow for collapsing question - include grade display inside answer box
- extend QuestionAnswerDetails to allow polymorphism - reuse existing answer type def for defining its mini version
- Multiple Choice - Multiple Response - Text Response (with/without attachments) - File Upload
- allowAttachment to be changed into maxAttachments nonzero - fix rubocop trailing whitespace issue
f6a881f
to
a4b00fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is the continuation of the previous PR #7077 and #7084 that adds feature allowing teacher to see the details of the answer when clicking on the grade box in the Assessment Statistics Page
This PR is related with the issue #4567
Feature Details
The display of the answer is as follows:
![Screenshot 2024-02-20 at 7 43 17 AM](https://private-user-images.githubusercontent.com/16359075/306094225-3e9c246e-4e2a-49b4-962e-432269457cd6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE5NDk1NjcsIm5iZiI6MTcyMTk0OTI2NywicGF0aCI6Ii8xNjM1OTA3NS8zMDYwOTQyMjUtM2U5YzI0NmUtNGUyYS00OWI0LTk2MmUtNDMyMjY5NDU3Y2Q2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI1VDIzMTQyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTliZWFiNmE0YjY2MWQwM2U1MjM2NjZkM2RmNjc5YzE4Zjk2NTcyY2UzZTk4NTM2YjQyZmI4ZDk0ZTdjNmQwNWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.1nDVH52BWwMXySjrIuY7lKXwiEulN0UjMaJF4Jx52Z8)
How to navigate:
Some consideration in the feature implementation:
TO-DO Lists
Future Improvement
Additional Notes
The codecov here noted some of the changes in BE not covered in the tests in RSpec. However, this will be later covered in the PR #7135