Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Answer Details in Assessment Statistics Page (Part 2: Last Graded Answer (Forum Post Response, Programming)) #7131

Open
wants to merge 45 commits into
base: bivan/teacher-stats-past-answer
Choose a base branch
from

Conversation

bivanalhar
Copy link
Contributor

@bivanalhar bivanalhar commented Feb 20, 2024

Background

This is the continuation of the previous PR #7130 that completes that mentioned PR by having the implementation for answer display for Forum Post Response and Programming

This PR is related with the issue #4567

Layout

Forum Post Response
Screenshot 2024-02-20 at 2 18 57 PM

Programming
Screenshot 2024-02-20 at 2 18 04 PM

TO-DO List

- when grader_ids does not exist within submission
- className cannot be defined dynamically within defining component
- reduce the cyclomatic complexity of marks_per_question API
- move most functions in controller to concern
- function to get mark cell classname out from component definition
- all codes into typescript
- ancestors in chronological order
- split all chart components into different tabs
- Change tab names to be more intuitive
- add toggle for phantom students inclusion setting
- display submission status chart on top instead of separate tabs
- change grade to totalGrade for submission
- group courseUser and grader information
- simplify type and interface definition
- display GhostIcon for phantom students
- refactor the props for includePhantom
- sort table based on phantom value, then name
- test for assessment, ancestors, and marks_per_question controller
- answers only passed on to view if workflow state is published
- split operations into several files depending on the object
- modify redux to support marks per question
- change the flow of the pages
- remove all redundant types
- remove some routes as being merged
- combine ancestor info and marks per question into main statistics
- remove all unnecessary controllers
- get the types correct to support migration of stats page to tsx
- make the reassignment of variable more consistent
- both uses the same component but different sources
- first get the necessary info, then display using common info
- remove the data from redux as it's unnecessary
- remove statisticsPage
- not include Phantom Students inside duplicated assessment stats
- use SQL to fetch all answers with all its relevant information
- autograded definition to be at least one question autogradable
- instead of sending group as list of names, now it's list of strings
for performance efficiency while getting statistics
- previously, it's from current_answer. this will be wrong if current_answer is attempting
- make the grade and attempt count box clickable
- each grade and attempt count cell is clickable
- after clicking, the box containing question will appear
- fetch question and answer details in one API
- use Accordion for question to allow for collapsing question
- include grade display inside answer box
- extend QuestionAnswerDetails to allow polymorphism
- reuse existing answer type def for defining its mini version
- Multiple Choice
- Multiple Response
- Text Response (with/without attachments)
- File Upload
@bivanalhar bivanalhar force-pushed the bivan/teacher-stats-past-answer branch from 288e29c to 5829efd Compare March 14, 2024 03:49
@bivanalhar bivanalhar force-pushed the bivan/teacher-stats-past-answer-2 branch from 934f775 to 9e9c7a7 Compare March 14, 2024 03:50
@bivanalhar bivanalhar force-pushed the bivan/teacher-stats-past-answer branch 2 times, most recently from 8aa52c6 to cd2abee Compare April 7, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant