Bundle resource bug fixes

[al-sabr]

Due to this thread I corrected the code so that it works.

#1025

[github-actions]

clang-tidy made some suggestions

[github-actions]

warning: explicitly assigning value of variable of type 'iterator' (aka '_Rb_tree_const_iterator<std::pair<std::basic_string, int>>') to itself [clang-diagnostic-self-assign-overloaded]

        for (iter=iter; iter != m_SortedEntries.end(); iter++)
                 ^

[jeffdiclemente]

These changes appear to be trying to work around a problem with a malformed or incorrectly built bundle.

[al-sabr]

These changes appear to be trying to work around a problem with a malformed or incorrectly built bundle.

The resource compile creates a default folder named resources-plugin and puts in it the manifest.json file. which is not made by me. I found it weird that the manifest.json is not in the root path of the zip file. And because of that the whole code with normalization is broken due to the path never found inside of the zip file

[al-sabr]

These changes appear to be trying to work around a problem with a malformed or incorrectly built bundle.

The resource compile creates a default folder named resources-plugin and puts in it the manifest.json file. which is not made by me. I found it weird that the manifest.json is not in the root path of the zip file. And because of that the whole code with normalization is broken due to the path never found inside of the zip file

[build] using compression level 6
[build] Initializing zip archive /mnt/dev/c++/bismika/bundles/resources-plugin/manifest.zip ...
[build] concatenated (pre-validated) json:
[build] {
[build] 	"bundle.activator" : true,
[build] 	"bundle.description" : "This bundle is a dummy resources container.",
[build] 	"bundle.name" : "Service Time SystemClock",
[build] 	"bundle.symbolic_name" : "resources-plugin",
[build] 	"bundle.version" : "1.0.0",
[build] 	"service-component" : true
[build] }
[build] 
[build] final (validated) manifest.json:
[build] {
[build] 	"bundle.activator" : true,
[build] 	"bundle.description" : "This bundle is a dummy resources container.",
[build] 	"bundle.name" : "Service Time SystemClock",
[build] 	"bundle.symbolic_name" : "resources-plugin",
[build] 	"bundle.version" : "1.0.0",
[build] 	"service-component" : true
[build] }
[build] 
[build] Adding file resources_plugin/manifest.json ...
[build] 	 new dir entry resources_plugin/
[build] Merging zip file /mnt/dev/c++/bismika/index.zip ... 
[build] 	merging: assets/ (from /mnt/dev/c++/bismika/index.zip) 
[build] 	 new dir entry assets/
[build] 	merging: assets/logo.png (from /mnt/dev/c++/bismika/index.zip) 
[build] 	merging: src/ (from /mnt/dev/c++/bismika/index.zip) 
[build] 	 new dir entry src/
[build] 	merging: src/index.html (from /mnt/dev/c++/bismika/index.zip) 
[build] 	merging: src/index.js (from /mnt/dev/c++/bismika/index.zip) 
[build] 	merging: style/ (from /mnt/dev/c++/bismika/index.zip) 
[build] 	 new dir entry style/
[build] 	merging: style/style.css (from /mnt/dev/c++/bismika/index.zip) 
[build] Finished merging files from /mnt/dev/c++/bismika/index.zip
[build] Finalizing the zip archive ...
[build] Archive has the following files
[build] 	 assets/logo.png
[build] 	 resources_plugin/manifest.json
[build] 	 src/index.html
[build] 	 src/index.js
[build] 	 style/style.css
[build] and directory entries
[build] 	 assets/
[build] 	 resources_plugin/
[build] 	 src/
[build] 	 style/
[build] using compression level 6
[build] Validating manifests in /mnt/dev/c++/bismika/bundles/resources-plugin/manifest.zip ... 
[build] 	Validating: resources_plugin/manifest.json (from /mnt/dev/c++/bismika/bundles/resources-plugin/manifest.zip) 
[build] 	Validating: resources_plugin/ (from /mnt/dev/c++/bismika/bundles/resources-plugin/manifest.zip) 
[build] 	Validating: assets/ (from /mnt/dev/c++/bismika/bundles/resources-plugin/manifest.zip) 
[build] 	Validating: assets/logo.png (from /mnt/dev/c++/bismika/bundles/resources-plugin/manifest.zip) 
[build] 	Validating: src/ (from /mnt/dev/c++/bismika/bundles/resources-plugin/manifest.zip) 
[build] 	Validating: src/index.html (from /mnt/dev/c++/bismika/bundles/resources-plugin/manifest.zip) 
[build] 	Validating: src/index.js (from /mnt/dev/c++/bismika/bundles/resources-plugin/manifest.zip) 
[build] 	Validating: style/ (from /mnt/dev/c++/bismika/bundles/resources-plugin/manifest.zip) 
[build] 	Validating: style/style.css (from /mnt/dev/c++/bismika/bundles/resources-plugin/manifest.zip) 
[build] Finished validating manifest files from style/style.css
[build] Appending file /mnt/dev/c++/bismika/build/plugins/libresources-plugind.so with contents of resources zip file at /mnt/dev/c++/bismika/bundles/resources-plugin/manifest.zip
[build]   Initial file size : 0
[build]   Final file size : 129696
[build] [100%] Built target resources_plugin
[driver] Build completed: 00:00:00.433

[al-sabr]

If you use my project : https://github.com/al-sabr/bismika

The loading of resources which are embedded in the shared library are recognized by the framework but if you replace the PR version by the original version from your repo it will not work at this line : https://github.com/al-sabr/bismika/blob/114b63a38d19f0bef3af008525209643db14bba8/cmake/cppmicroservices.cmake#L7