scope.chargement is not always null #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t" while everyone else will show "Loading" Now it doesn't have the Open & Close principle. (https://en.wikipedia.org/wiki/Open/closed_principle) Open for extension and closed for modification. This should make it easy for future language translations to be added by individiuals going forward.
This is perfect now. Together we made perfection
…lExtended # Conflicts: # compile/minified/ng-img-crop.js # compile/unminified/ng-img-crop.js # source/js/ng-img-crop.js
rickerd
approved these changes
Sep 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, scope.chargement resolves to undefined.