Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSC Dashboard #2

Merged
merged 42 commits into from
Nov 1, 2018
Merged

RSC Dashboard #2

merged 42 commits into from
Nov 1, 2018

Conversation

Prozak8
Copy link
Collaborator

@Prozak8 Prozak8 commented Oct 31, 2018

PT Link

https://www.pivotaltracker.com/story/show/161589349

Inculded in PR

  • Working from jobs user flow
  • Navbar with title
  • Sidebar with jobs, hospitals and staffing companies
  • Jobs controller
  • Language toggle (en/sv)

Screenshot

screenshot 2018-11-01 at 17 14 27

@coveralls
Copy link

coveralls commented Oct 31, 2018

Pull Request Test Coverage Report for Build 21

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-18.0%) to 32.0%

Files with Coverage Reduction New Missed Lines %
app/models/application_record.rb 3 0.0%
Totals Coverage Status
Change from base Build 7: -18.0%
Covered Lines: 8
Relevant Lines: 25

💛 - Coveralls

@Prozak8 Prozak8 changed the title RSC Dashboard [WIP] RSC Dashboard Nov 1, 2018
Copy link
Collaborator

@rupertlion rupertlion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename all the ca styling classes (in a chore). Probably ok for now, but we need to review and change.

We should also comment on the PT item that we have not included the indexing of jobs and hospitals here (except for as placeholders) as we have extracted to other user stories (ie RSC can see list of jobs)

Also worth commenting that further styling is required on integration with other features (eg lists of items)

app/views/partials/_header.html.haml Outdated Show resolved Hide resolved
@Prozak8 Prozak8 requested a review from tochman November 1, 2018 13:58
@RhonGabriel RhonGabriel merged commit 20ec1e4 into CraftAcademy:development Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants