Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup ci #12

Merged
merged 10 commits into from
Jan 7, 2020
Merged

Setup ci #12

merged 10 commits into from
Jan 7, 2020

Conversation

Oyelaw
Copy link
Collaborator

@Oyelaw Oyelaw commented Jan 6, 2020

  • added CircleCI 2.0 workflow configuration
  • add coverage status badge
  • add config.yml file
  • add coveralls status badge
  • add cover alls to test script
  • add coveralls package
  • add test.config.json and jest-unit test

Copy link
Collaborator

@Ehbraheem Ehbraheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few comments

README.md Outdated
@@ -1,3 +1,6 @@
[![CircleCI](https://circleci.com/gh/jabdul/apig.svg?style=svg)](https://circleci.com/gh/jabdul/apig)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this.

This is a private repo status badge will probably come with a CCI token.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay will do

README.md Outdated Show resolved Hide resolved
@Ehbraheem Ehbraheem requested review from jabdul and removed request for justmic007 January 6, 2020 15:07
@Ehbraheem Ehbraheem dismissed their stale review January 6, 2020 15:27

All changes has been added

@Oyelaw Oyelaw requested review from Ehbraheem and justmic007 and removed request for justmic007 January 6, 2020 15:34
README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants