Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge CANI command with provider command #159

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Merge CANI command with provider command #159

merged 2 commits into from
Nov 27, 2023

Conversation

jacobsalmela
Copy link
Collaborator

Summary and Scope

  • Moves New*Command() functions into init.go since they get called during init()
  • Add a MergeProviderCommand() function to merge the CANI command with the command defined by the provider

Risks and Mitigations

Low

@jacobsalmela
move New*Command() functions to init.go for csm provider
5951133 
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
@jacobsalmela
add MergeProviderCommand() function to merge CANI commands with
12e9802 
provider-defined commands

Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
@jacobsalmela jacobsalmela self-assigned this Nov 22, 2023
@jacobsalmela jacobsalmela marked this pull request as ready for review November 22, 2023 16:50
@jacobsalmela jacobsalmela changed the title Trusting the leader Merge CANI command with provider command Nov 22, 2023
@jacobsalmela jacobsalmela merged commit e1efb24 into develop Nov 27, 2023
5 checks passed
@jacobsalmela jacobsalmela deleted the trusting-the-leader branch November 27, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shunr-hpe shunr-hpe shunr-hpe approved these changes

Assignees

@jacobsalmela jacobsalmela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobsalmela @shunr-hpe