make cani netbox package and vendor #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
… schema (needs human munging at present) Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
shunr-hpe
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
*netbox's device-type-library has defines a schema, but it does not necessarily match the netbox API (see netbox-community/go-netbox#168 (comment)). Because of this, I am adding this netbox package so we can track the differences and make adjustments in CANI. Also,
go-jsonschemacan generate nice.gofiles, but they needed a little massaging to plug in nice with CANI's types and not have unfriendly names. If there is something better to save me from writing all that code, I'd like to know, but this was the best I found at present.Risks and Mitigations
Low. Not being used in main currently but making this PR more digest-able, as well as those that follow.