-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CASM-3506: Add IUF support #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haasken-hpe
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor comments.
jack-stanek-hpe
force-pushed
the
CASM-3506-adapt-for-iuf
branch
from
November 29, 2022 22:54
3e602dc
to
452c922
Compare
haasken-hpe
requested changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a minor bug with rstrip
usage
haasken-hpe
approved these changes
Nov 30, 2022
jsollom-hpe
approved these changes
Dec 6, 2022
jack-stanek-hpe
force-pushed
the
CASM-3506-adapt-for-iuf
branch
3 times, most recently
from
December 7, 2022 23:02
b910244
to
81c4c3b
Compare
This change adds support for the IUF in the `load-ims-artifacts` image in order to implement the ims-upload operation. It requires that the IUF release distribution be mounted within the container, and that the `IUF` and `IUF_RELEASE_PATH` environment variables be set. Other environment variables must be set within the container as normal. Existing `load-ims-artifacts` images should still be compatible with this change. Additionally, `manifest.yaml` files from existing `load-ims-artifacts` images can be used with the IUF ims-upload operation, maintaining backwards compatibility. This change also establishes a 2.0.0 release of the `ims-load-artifacts` package for the IUF impelmentation. Test Description: Run IUF workflows using enumerated IUF manifests and existing content directories. Ensure that content is uploaded as expected.
jack-stanek-hpe
force-pushed
the
CASM-3506-adapt-for-iuf
branch
from
December 8, 2022 21:59
81c4c3b
to
7a26bf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
This change adds support for the IUF in the
load-ims-artifacts
image in order to implement the ims-upload operation. It requires that the IUF release distribution be mounted within the container, and that theIUF
andIUF_RELEASE_PATH
environment variables be set. Other environment variables must be set within the container as normal.Existing
load-ims-artifacts
images should still be compatible with this change. Additionally,manifest.yaml
files from existingload-ims-artifacts
images can be used with the IUF ims-upload operation, maintaining backwards compatibility.Issues and Related PRs
Testing
Tested on:
frigg
,mug
Test description:
Run IUF workflows using enumerated IUF manifests and existing content directories. Ensure that content is uploaded as expected.
Risks and Mitigations
Does not affect existing implementation.
Pull Request Checklist