Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASM-3506: Add IUF support #29

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Conversation

jack-stanek-hpe
Copy link
Contributor

Summary and Scope

This change adds support for the IUF in the load-ims-artifacts image in order to implement the ims-upload operation. It requires that the IUF release distribution be mounted within the container, and that the IUF and IUF_RELEASE_PATH environment variables be set. Other environment variables must be set within the container as normal.

Existing load-ims-artifacts images should still be compatible with this change. Additionally, manifest.yaml files from existing load-ims-artifacts images can be used with the IUF ims-upload operation, maintaining backwards compatibility.

Issues and Related PRs

Testing

Tested on:

  • frigg, mug
  • Local development environment

Test description:

Run IUF workflows using enumerated IUF manifests and existing content directories. Ensure that content is uploaded as expected.

Risks and Mitigations

Does not affect existing implementation.

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

Copy link
Collaborator

@haasken-hpe haasken-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor comments.

constraints.txt Outdated Show resolved Hide resolved
ims_load_artifacts/iuf.py Outdated Show resolved Hide resolved
ims_load_artifacts/iuf.py Outdated Show resolved Hide resolved
ims_load_artifacts/iuf.py Outdated Show resolved Hide resolved
ims_load_artifacts/iuf.py Show resolved Hide resolved
ims_load_artifacts/loaders.py Show resolved Hide resolved
tests/test_iuf.py Show resolved Hide resolved
tests/test_iuf.py Outdated Show resolved Hide resolved
tests/test_iuf.py Outdated Show resolved Hide resolved
tests/test_iuf.py Show resolved Hide resolved
Copy link
Collaborator

@haasken-hpe haasken-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a minor bug with rstrip usage

ims_load_artifacts/iuf.py Outdated Show resolved Hide resolved
ims_load_artifacts/iuf.py Outdated Show resolved Hide resolved
@jack-stanek-hpe jack-stanek-hpe force-pushed the CASM-3506-adapt-for-iuf branch 3 times, most recently from b910244 to 81c4c3b Compare December 7, 2022 23:02
This change adds support for the IUF in the `load-ims-artifacts` image
in order to implement the ims-upload operation. It requires that the IUF
release distribution be mounted within the container, and that the `IUF`
and `IUF_RELEASE_PATH` environment variables be set. Other environment
variables must be set within the container as normal.

Existing `load-ims-artifacts` images should still be compatible with
this change. Additionally, `manifest.yaml` files from existing
`load-ims-artifacts` images can be used with the IUF ims-upload
operation, maintaining backwards compatibility.

This change also establishes a 2.0.0 release of the `ims-load-artifacts`
package for the IUF impelmentation.

Test Description:
Run IUF workflows using enumerated IUF manifests and existing content
directories. Ensure that content is uploaded as expected.
@jack-stanek-hpe jack-stanek-hpe merged commit cae52fa into develop Dec 8, 2022
@jack-stanek-hpe jack-stanek-hpe deleted the CASM-3506-adapt-for-iuf branch December 8, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants