Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use C++11 override keyword #214

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Use C++11 override keyword #214

merged 1 commit into from
Feb 16, 2022

Conversation

billschereriii
Copy link
Contributor

Update the exception hierarchy to use the C++11 override keyword

@billschereriii billschereriii added the area: C++ Issues related to the C++ client label Feb 15, 2022
@billschereriii billschereriii self-assigned this Feb 15, 2022
@billschereriii
Copy link
Contributor Author

This generated a warning on theta

mellis13
mellis13 approved these changes Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the compiler warning. Which C++ compiler raised the warning? It might we worth considering adding to our test matrix in a future PR.

LGTM

@billschereriii billschereriii merged commit 7ba80c8 into CrayLabs:develop Feb 16, 2022
@billschereriii billschereriii deleted the override branch February 16, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mellis13 mellis13 mellis13 approved these changes

Assignees

@billschereriii billschereriii

Labels
area: C++ Issues related to the C++ client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billschereriii @mellis13