Minor fixes to full_wlm tests #283
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #283 +/- ##
===========================================
- Coverage 87.64% 87.58% -0.06%
===========================================
Files 60 60
Lines 3374 3374
===========================================
- Hits 2957 2955 -2
- Misses 417 419 +2
|
There was a problem hiding this comment.
LGTM and everything is passing on my end!
I found one little potential anti-pattern in test_slurm_allocation they maybe worth cleaning up, but not strictly necessary to fix here.
I also made some notes about potential features to add to BatchSettings in the future, but both are probably well out-of-scope for this PR, so feel free to ignore them for now!
| alloc = slurm.get_allocation(nodes=1, time="00:05:00") | ||
| account = wlmutils.get_test_account() | ||
| if not account: | ||
| account = None |
There was a problem hiding this comment.
This feels a bit like an anti-pattern. Should wlmutils.get_test_account and/or CONFIG.test_account just return None if SMARTSIM_TEST_ACCOUNT is not set, instead of an empty string?
There was a problem hiding this comment.
How come you always have such good ideas. Indeed, updated.
| orc.batch_settings.set_walltime("00:02") | ||
| else: | ||
| orc.batch_settings.set_walltime("00:02:00") |
There was a problem hiding this comment.
Out of scope for this PR, more-so just a note to myself for a potential addition to BatchSettings class:
This feels like there is probably a way to unify these set_walltime calls so that we do not need to jump based on launcher. Maybe something akin to RunSettings.set_time.
Thoughts?
There was a problem hiding this comment.
All of a sudden, you reminded me that we can actually specify time like that in LSF, because we convert it to hh:mm format on the fly. Removing outdated lines.
|
|
||
| test_account = wlmutils.get_test_account() | ||
| if test_account: | ||
| orc.batch_settings.set_account(test_account) |
There was a problem hiding this comment.
Out of scope for this PR, more-so a note to myself for a potential BatchSettings feature:
Iirc, for SBatchSettings, if set_account receives a false-y value (i.e. empty str or None), a no-op is made.
Is this not the case for all BatchSettings derivatives? Should we consider unifying this behavior for script portability??
There was a problem hiding this comment.
It should be, indeed. I updated LSF, which was the only one with a slightly different behavior (due to the fact that accounts are always needed on LSF).
This PR addresses some minor errors encountered on new systems when running
make test-full.