Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty print error message when onnx wheel not available #359

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

MattToast
Copy link
Member

In the case where a user is using python 3.10 and has requested to build with

smart build --onnx

there is no compliant onnx wheel for python 3.10 for the ORT backend installed by default for RAI. This was leading to a SetupError being raised, and eventually exposing itself to the user.

This PR will handle that raised exception and pretty print the error message within, before exiting with a non-zero exit code.

@MattToast MattToast added the area: build Issues related to builds, makefiles, installs, etc label Sep 11, 2023
@MattToast MattToast self-assigned this Sep 11, 2023
Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #359 (b1e4fe5) into develop (b459bf2) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #359      +/-   ##
===========================================
+ Coverage    88.37%   88.54%   +0.16%     
===========================================
  Files           59       59              
  Lines         3580     3580              
===========================================
+ Hits          3164     3170       +6     
+ Misses         416      410       -6     

@MattToast MattToast merged commit 74abcc3 into CrayLabs:develop Sep 11, 2023
10 checks passed
@MattToast MattToast deleted the pprint-no-onnx-avail branch September 12, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Issues related to builds, makefiles, installs, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants