Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MINBATCHTIMEOUT #387

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Add support for MINBATCHTIMEOUT #387

merged 4 commits into from
Oct 6, 2023

Conversation

billschereriii
Copy link
Contributor

Paralleling the implementation of support for min_batch_size

@billschereriii billschereriii added area: orchestrator Issues related to the Ochestrator API, launch, and runtime API break Issues that include incompatible API changes labels Oct 5, 2023
@billschereriii billschereriii self-assigned this Oct 5, 2023
al-rigazzi
al-rigazzi requested changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except for a tiny typo in the changelog. Otherwise LGTM!

doc/changelog.rst Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

Merging #387 (97be85f) into develop (7eaab83) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #387   +/-   ##
========================================
  Coverage    89.52%   89.52%           
========================================
  Files           58       58           
  Lines         3571     3571           
========================================
  Hits          3197     3197           
  Misses         374      374
Files Coverage Δ
smartsim/_core/utils/redis.py 87.50% <ø> (ø)
smartsim/entity/ensemble.py 99.25% <ø> (ø)
smartsim/entity/model.py 95.59% <ø> (ø)

ashao
ashao approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@al-rigazzi al-rigazzi self-requested a review October 6, 2023 19:08
al-rigazzi
al-rigazzi approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing this so quickly!

@billschereriii billschereriii merged commit f00c426 into CrayLabs:develop Oct 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashao ashao ashao approved these changes

@al-rigazzi al-rigazzi al-rigazzi approved these changes

Assignees

@billschereriii billschereriii

Labels
API break Issues that include incompatible API changes area: orchestrator Issues related to the Ochestrator API, launch, and runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@billschereriii @ashao @al-rigazzi