Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate launched model names from full test suite #520

Merged

Conversation

MattToast
Copy link
Member

Removes behavior deprecated in #480 from test suite.

@MattToast MattToast added the area: test Issues related to the test suite label Mar 13, 2024
@MattToast MattToast requested a review from ashao March 13, 2024 18:39
@MattToast MattToast self-assigned this Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.73%. Comparing base (e307b72) to head (9648565).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #520   +/-   ##
========================================
  Coverage    90.73%   90.73%           
========================================
  Files           60       60           
  Lines         3830     3830           
========================================
  Hits          3475     3475           
  Misses         355      355           

@MattToast MattToast requested a review from mellis13 March 15, 2024 20:53
Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MattToast MattToast merged commit 6dea582 into CrayLabs:develop Mar 18, 2024
44 checks passed
@MattToast MattToast deleted the no-dup-model-names-in-test-suite branch March 29, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: test Issues related to the test suite non-user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants