-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote Build Device Option to Enum #527
Promote Build Device Option to Enum #527
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #527 +/- ##
===========================================
- Coverage 90.69% 90.66% -0.04%
===========================================
Files 65 65
Lines 4494 4497 +3
===========================================
+ Hits 4076 4077 +1
- Misses 418 420 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I have a couple of small suggestions, but looks about ready to go on my end! Feel free to LMK what you think!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending tests!! Thanks for adding a bit more type safety!
Removing instances of ["CPU","GPU"] with an
Device
instance