Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Testing section in README #7

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

bwaidelich
Copy link
Contributor

The Testing section referred to a non-existing composer script test

The Testing section referred to a non-existing composer script `test`
@bwaidelich
Copy link
Contributor Author

Let me know if you want me to add the missing composer script instead and I'll push a follow-up

@Crell
Copy link
Owner

Crell commented Mar 21, 2024

We've got a phpstan script, so may as well make one for tests. Although I rarely use them, as for reasons I've never figured out running a composer script when xdebug is enabled just hangs, at least on my Docker images. I've yet to figure out why... 😢

In any case, yes, let's add the script instead to match the readme.

@bwaidelich
Copy link
Contributor Author

We've got a phpstan script, so may as well make one for tests

Done.
I did not adjust Makefile and quality-assurance.yaml to use the script since they weren't using the phpstan script either

running a composer script when xdebug is enabled just hangs

uh? I've never experienced that

@Crell
Copy link
Owner

Crell commented Mar 22, 2024

uh? I've never experienced that

Yeah, I can't explain it either.

Thanks!

@Crell Crell merged commit 6dc678c into Crell:master Mar 22, 2024
6 checks passed
@bwaidelich bwaidelich deleted the task/tweak-readme branch March 22, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants