Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move phpstan/phpstan to require-dev #19

Merged
merged 3 commits into from
Jun 2, 2022
Merged

Conversation

martinssipenko
Copy link
Contributor

Description

Move phpstan/phpstan to require-dev so that it's not installed in projects using this package.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@martinssipenko
Copy link
Contributor Author

@Crell I'd really appreciate a release of this change as currently when updating to the latest version of this package, PHPSTan is installed when it should really not be. I caught this because the project where I use this package still uses an older version of PHPStan (0.12.x) and is now conflicting with 1.4.0 of this package.

composer.json Outdated Show resolved Hide resolved
@Crell
Copy link
Owner

Crell commented Jun 1, 2022

Hm, good call. That was probably just sloppiness on my part, sorry. Though where is the extra plugin coming from? Once that's resolved I'm good with merging.

@martinssipenko
Copy link
Contributor Author

CI is failing on 7.4 but I don't believe it's caused by my changes.

@Crell Crell merged commit 319a0a0 into Crell:master Jun 2, 2022
@Crell
Copy link
Owner

Crell commented Jun 2, 2022

Kicked CI, works now. No idea what happened there.

Merged. Thanks! I'll tag a new release sometime today; I may as well see if there's any other small cleanup to do while I'm here.

@martinssipenko martinssipenko deleted the phpstan branch June 2, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants