Setup PlayWright tests #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
harmen-xb
commented
Nov 22, 2023
•
harmen-xb
commented
- Setup PlayWright test package (e2e-tests).
- Implemented CrossModel page object model (including some generic Theia ones which might be migrated to Theia in the future).
- Created 3 spec files to test basic CrossModel functionalities (to be extended in future).
- Setup execution of PlayWright and reporting in GitHub Workflow.
- Updated devcontainer configuration so PlayWright can be debugged from Windows machine (using WSL + Docker).
…dingly. Added allure reporting for ci runs and added dependencies.
Updated e2e-tests package file.
Reverted back to using pages actions and added environment setting.
…object. Created scenarios for tab bar toolbar actions (entity, relationship & diagram).
Moved tabbar-toolbar tests into own spec file. Added getting focus on explorer for each test in toolbar tests.
martin-fleck-at
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Fantastic contribution! For me locally everything works as expected and the initial CI ran with this PR also looks good. For the reporting, we need to merge to master I believe but I didn't see any obvious problems so far. I especially like the custom page objects, great work!
I do have some minor comments but they are mostly related to style.
Changed use of type in the input dialog to fill (because of deprecation warning). Renamed xmodel files to crossmodel. Added instlal-playwright yarn script for e2e-tests package. Added ui-test yarn script for workspace package json. Updated gitflow workflows to use adjusted yarn scripts.
martin-fleck-at
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.