Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setup.py for docutils dependency #69

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Update setup.py for docutils dependency #69

wants to merge 1 commit into from

Conversation

adrien-berchet
Copy link

@adrien-berchet adrien-berchet commented Apr 18, 2024 •
edited
Loading

Fixes #68

@adrien-berchet adrien-berchet mentioned this pull request Apr 22, 2024
Closed
@adrien-berchet
Copy link
Author

Any update on this @CrossNox ?

@bgyori
Copy link

bgyori commented Jul 17, 2024

I ran into the same issue, it would be great if this PR could be merged and a new release put on PyPI. Thank you!

@ReenigneArcher ReenigneArcher mentioned this pull request Jul 31, 2024
Open
2xB added a commit to 2xB/m2r2 that referenced this pull request Oct 15, 2024
@2xB
Avoid docutils.nodes.reprunicode
4408b84 
`docutils.nodes.reprunicode` was until recently just a subclass of `str`. It was removed in this commit: https://sourceforge.net/p/docutils/code/9415/
Therefore `path = nodes.reprunicode(path)` just converted a string to a string and can therefore be removed.

This is an alternative to fixing `docutils` to an old version (as done in CrossNox#69).

Fixes CrossNox#68
@2xB 2xB mentioned this pull request Oct 15, 2024
Open
@2xB
Copy link

2xB commented Oct 15, 2024 •
edited
Loading

I just created a simple PR #71 that removes the use of reprunicode instead of pinning docutils to an old version. I did not get to test it with a recent version of docutils to see if there are any other issues with the newest docutils since the issue currently only exists for me in a CI pipeline (if that is trivial for someone, I'd highly appreciate a quick test), however I would prefer that solution over pinning docutils in this repository of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docutils 0.21 has removed nodes.reprunicode() and therefore building documentation using m2r2 fails
3 participants
@adrien-berchet @bgyori @2xB