Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong hash generated for star activities #407

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Jan 9, 2023

Changes proposed ✍️

  • Webhooks and onboardings were generating different hashes because webhooks were using the UNIX timestamp string, but onboardings were using the date string when generating the sourceId hash.
  • Now, onboardings also use the UNIX timestamp when generating the hash.
  • Also, there's a temp fix in automations, where we discard the star activities temporarily (Will onboard GitHub integrations and remove this part)

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@epipav epipav self-assigned this Jan 9, 2023
@epipav epipav added the Bug Created by Linear-GitHub Sync label Jan 9, 2023
@epipav epipav requested a review from themarolt January 9, 2023 13:36
@epipav epipav marked this pull request as ready for review January 9, 2023 13:36
@epipav epipav merged commit 3a5c94b into main Jan 10, 2023
@epipav epipav deleted the bugfix/wrong-timestamp-hash-string-in-star-activities branch January 10, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants