add terraform example for official pacakge #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffalor
force-pushed
the
terraform
branch
2 times, most recently
from
f02d98a
to
6afb571
Compare
Co-authored-by: Carlos Matos <matosc15@gmail.com>
Co-authored-by: Carlos Matos <matosc15@gmail.com>
|
|
||
| This terraform code will create a AWS State Manager assocation that will install the CrowdStrike Falcon Sensor on all EC2 instances in a region. The CrowdStrike Falcon Sensor is installed using the Official CrowdStrike Distributor package. | ||
|
|
||
| By default the terraform code will deploy to all regions supported by the Official Distributor package that are enabled on your account. |
There was a problem hiding this comment.
Suggested change
| By default the terraform code will deploy to all regions supported by the Official Distributor package that are enabled on your account. | |
| **By default the terraform code will deploy to all regions supported by the Official Distributor package that are enabled on your account.** |
I would consider making this either bold as suggested, or use an alert like below:
Important
By default the terraform code will deploy to all regions supported by the Official Distributor package that are enabled on your account.
There was a problem hiding this comment.
Merged all those other suggestions imo this one isn't more important than the other paragraphs explaining the purpose of the module. Thoughts?
There was a problem hiding this comment.
🤷🏼♂️ I feel like this is one of those points where someone will undoubtedly go.. oh.. I didn't know it would deploy to all the regions by default lol.. I was just trying to highlight that this is the default.
carlosmmatos
requested changes
Oct 31, 2023
Co-authored-by: Carlos Matos <matosc15@gmail.com>
official-package/terraform/README.md
Outdated
| | Name | Description | Type | Default | Required | | ||
| | --------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------ | -------------- | ------------------------------------ | :------: | | ||
| | aws_regions | The AWS Regions to deploy the CrowdStrike Falcon Sensor to. Defaults to every region the Official Distributor supports. | `list(string)` | `[]` | no | | ||
| | exclude_aws_regions | The AWS Regions to exclude from deployment. Defaults to none. Useful for when you want to deploy to most supported except a few. | `list(string)` | `[]` | no | |
There was a problem hiding this comment.
Suggested change
| | exclude_aws_regions | The AWS Regions to exclude from deployment. Defaults to none. Useful for when you want to deploy to most supported except a few. | `list(string)` | `[]` | no | | |
| | exclude_aws_regions | The AWS Regions to exclude from deployment. Defaults to none. Ideal when you aim to deploy to all supported regions except for a specified few. | `list(string)` | `[]` | no | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.