fix: toStyle, convert minWidth to min-width #149
Conversation
🦋 Changeset detectedLatest commit: f2a47bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Preview URLsGH Env: preview |
|
Hopefully unblocking: #150 |
There was a problem hiding this comment.
Approved, but as Preston noted, this should have a changelog entry, and cause a version bump, otherwise we can't get this released (I think?):
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Yeah I think it might be this test: https://github.com/CrowdStrike/ember-headless-table/blob/main/test-app/tests/plugins/sticky-columns/rendering-rfc-883-test.gts Will take a look at updating it...looks like we test there for stickiness but not the |
| await helpers.scrollRight(200); | ||
|
|
||
| /** | ||
| * Because we only scrolled the distance of one column for this test, | ||
| * it doesn't make sense to check the other columns. | ||
| */ | ||
| left = leftPositionOf('A'); | ||
| await this.pauseTest(); |
There was a problem hiding this comment.
I know...I am having issues running the tests locally...see below:
To get around this, I was using CI and dropping in console.logs but forgot to remove this pauseTest initially.
Then I realized pnpm test:ember still works and realized I was pausing tests.
There was a problem hiding this comment.
This looks a lot like an issue with ember-auto-import, where @cached isn't defined.
See: embroider-build/ember-auto-import#504
Make sure you're using ember-auto-import@^2.6.2
There was a problem hiding this comment.
Thank you SO MUCH!! This fixes it...going to put up another PR for this.
nicolechung
force-pushed
the
fix_minWidth_in_style_helper
branch
3 times, most recently
from
418eb90
to
452bec9
Compare
nicolechung
force-pushed
the
fix_minWidth_in_style_helper
branch
from
452bec9
to
4b086d8
Compare
nicolechung
force-pushed
the
fix_minWidth_in_style_helper
branch
from
b470f5d
to
f2a47bf
Compare
Description
Some folks are having issues rendering the columns
minWidthstyle because they style tag looks like:Instead of:
This hopefully fixes that?