Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade embroider deps #261

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Upgrade embroider deps #261

wants to merge 8 commits into from

Conversation

ynotdraw
Copy link
Contributor

@ynotdraw ynotdraw commented Aug 23, 2023

🚀 Description

Closes #210 after some help in the Ember Discord + @NullVoxPopuli 🙇


🔬 How to Test

  • Green build
  • Docs app should not blow up when you open the preview URL
  • Local development should still work as you'd expect

📸 Images/Videos of Functionality

N/A

@ynotdraw ynotdraw self-assigned this Aug 23, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2023

⚠️ No Changeset found

Latest commit: d258315

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ynotdraw ynotdraw closed this Aug 23, 2023
@ynotdraw ynotdraw reopened this Aug 23, 2023
@github-actions
Copy link
Contributor

Preview URLs

Env: preview
Docs: https://e164cf93.ember-toucan-core.pages.dev

@ynotdraw ynotdraw marked this pull request as ready for review August 23, 2023 17:15
Comment on lines +8 to +10
@import '@crowdstrike/ember-oss-docs/styles/tailwind-extensions.css';
@import '@crowdstrike/ember-oss-docs/styles/docfy-overrides.css';
@import '@crowdstrike/ember-oss-docs/styles/hljs.css';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NullVoxPopuli the problem with this now is that if you visit https://e164cf93.ember-toucan-core.pages.dev/, you'll see the CSS not being applied. Do we need to tell Webpack about this by adding a CSS Loader of sorts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible that https://github.com/CrowdStrike/ember-oss-docs/blob/main/ember-oss-docs/package.json#L167 needs to be expanded to differentiate between js and css.
otherwise, it wouldn't be too farfetched to include ./dist/styles in exports so that both webpack and the css-loader are happy.

it turns out googling exports and webpack together is really hard, due to CJS 😅

Some back and forth with AI suggested using resolve.alias, but that's less fun. may work tho

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, alternatively, these 3 files could be imported in a js file.

@ynotdraw ynotdraw marked this pull request as draft August 24, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get this repo working with embroider v3+
2 participants