-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade embroider deps #261
base: main
Are you sure you want to change the base?
Conversation
|
Preview URLsEnv: preview |
@import '@crowdstrike/ember-oss-docs/styles/tailwind-extensions.css'; | ||
@import '@crowdstrike/ember-oss-docs/styles/docfy-overrides.css'; | ||
@import '@crowdstrike/ember-oss-docs/styles/hljs.css'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NullVoxPopuli the problem with this now is that if you visit https://e164cf93.ember-toucan-core.pages.dev/, you'll see the CSS not being applied. Do we need to tell Webpack about this by adding a CSS Loader of sorts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible that https://github.com/CrowdStrike/ember-oss-docs/blob/main/ember-oss-docs/package.json#L167 needs to be expanded to differentiate between js and css.
otherwise, it wouldn't be too farfetched to include ./dist/styles
in exports so that both webpack and the css-loader are happy.
it turns out googling exports
and webpack
together is really hard, due to CJS 😅
Some back and forth with AI suggested using resolve.alias
, but that's less fun. may work tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, alternatively, these 3 files could be imported in a js file.
🚀 Description
Closes #210 after some help in the Ember Discord + @NullVoxPopuli 🙇
🔬 How to Test
📸 Images/Videos of Functionality
N/A