Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ BUG ] Payload creation error in command_payload body payload handler in Real Time Response Service Class #568

Closed
jshcodes opened this issue Feb 24, 2022 · 0 comments · Fixed by #569
Closed

[ BUG ] Payload creation error in command_payload body payload handler in Real Time Response Service Class #568

jshcodes opened this issue Feb 24, 2022 · 0 comments · Fixed by #569
Assignees
@jshcodes
Labels
bug 🐛 Something isn't working RTR Real Time Response issues and questions

Comments

@jshcodes
Copy link
Member

Describe the bug
There is a typo / bug in the Real Time Response body payload handler, command_payload. (key should be boolean)

To Reproduce
Try to pass "queue_offline" to the batch_init_sessions method of the Real Time Response Service Class. This value will not make it to the final body payload (nor will any other boolean in this handler).

Developers making use of standard body payloads with this method will not encounter this issue.

Expected behavior
The body payload is properly formulated.

Environment (please complete the following information):

  • OS: All supported
  • Python: All supported
  • FalconPy: 0.7.3 - 1.0.4

Additional context
Discovered while developing a sample for discussion #415.
@jshcodes jshcodes added bug 🐛 Something isn't working RTR Real Time Response issues and questions labels Feb 24, 2022
@jshcodes jshcodes self-assigned this Feb 24, 2022
jshcodes added a commit that referenced this issue Feb 24, 2022
@jshcodes
Fix typo in body payload handler. Closes #568.
4e509b4
jshcodes added a commit that referenced this issue Feb 24, 2022
@jshcodes
Fix typo in body payload handler. Closes #568.
36421df
@jshcodes jshcodes mentioned this issue Feb 24, 2022
Merged
3 tasks
jshcodes added a commit that referenced this issue Feb 24, 2022
@jshcodes
Fix typo in body payload handler. Closes #568.
6095454
@jshcodes jshcodes mentioned this issue Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshcodes jshcodes

Labels
bug 🐛 Something isn't working RTR Real Time Response issues and questions
Projects
None yet
Milestone
No milestone
1 participant
@jshcodes