Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ BUG ] Import-FalconConfig ignores FirewallGroup #380

Closed
bk-cs opened this issue Jan 23, 2024 · 2 comments
Closed

[ BUG ] Import-FalconConfig ignores FirewallGroup #380

bk-cs opened this issue Jan 23, 2024 · 2 comments
Assignees
@bk-cs
Labels
bug Something isn't working fix available Self-applied fix available in issue

Comments

@bk-cs
Copy link
Collaborator

bk-cs commented Jan 23, 2024

Describe the bug
When attempting to use Import-FalconConfig with an archive that has one or more FirewallGroup items, it is ignored

To Reproduce
Create an export that includes FirewallGroup (either by itself, or with other items like FirewallPolicy) and attempt to import

Expected behavior
Successful FirewallGroup creation

Environment (please complete the following information):

  • OS: Windows 11, macOS
  • PowerShell: 5.1, 7.4
  • PSFalcon: 2.2.6
@bk-cs bk-cs added the bug Something isn't working label Jan 23, 2024
@bk-cs bk-cs self-assigned this Jan 23, 2024
bk-cs added a commit that referenced this issue Jan 23, 2024
@bk-cs
Update psf-config.ps1
4ba4a56 
Issue #380

Updated `Compare-ImportData` function to analyze items by each individual `platform` (or `platform_name`) to resolve bug where `FirewallGroup` items were being ignored

Added additional verbose messaging to indicate how items are being compared during import
@bk-cs
Copy link
Collaborator Author

bk-cs commented Jan 23, 2024 •
edited
Loading

This issue will be fixed in the next release. If you'd like to resolve it for your local module before release, you can replace public\psf-config.ps1 using the steps outlined below.

Import-Module -Name PSFalcon
$ModulePath = (Show-FalconModule).ModulePath
(Invoke-WebRequest -Uri https://raw.githubusercontent.com/CrowdStrike/psfalcon/436359c40767a614b03694c81d8333a9f2a639e5/public/psf-config.ps1 -UseBasicParsing).Content > (Join-Path (Join-Path $ModulePath public) psf-config.ps1)

Once the fix has been applied, you must restart PowerShell and re-import PSFalcon.

EDIT: Updated link to include recent commit because of accidental removal of fix.

@bk-cs bk-cs added the fix available Self-applied fix available in issue label Feb 27, 2024
bk-cs added a commit that referenced this issue May 21, 2024
@bk-cs
Issue #380
436359c 
Reapplying some bug fixes that were implemented for properly evaluating `FirewallGroup` and accidentally removed in a later commit
@bk-cs bk-cs mentioned this issue Sep 3, 2024
Merged
@bk-cs
Copy link
Collaborator Author

bk-cs commented Sep 4, 2024

This fix is included in the 2.2.7 release.

@bk-cs bk-cs closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bk-cs bk-cs

Labels
bug Something isn't working fix available Self-applied fix available in issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bk-cs