Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#177824342]: refactor sig letters for means #282

Merged
merged 6 commits into from
Apr 21, 2021

Conversation

ernestoarbitrio
Copy link
Contributor

No description provided.

ernestoarbitrio and others added 2 commits April 20, 2021 15:49
* Refactor pairwise means significance classes as they were before the
  refactor for subtotals
* Implement converting UI column index to base column index
* Implement converting base pairwise indices from measure class to
  assembled pairwise indices from assembler
@slobodan-ilic slobodan-ilic force-pushed the refactor-sig-letters-means-177824342 branch from 9a03e6f to dfedd08 Compare April 20, 2021 16:09
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #282 (6bb215f) into master (4705ad8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #282   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         3955      3933   -22     
=========================================
- Hits          3955      3933   -22     
Impacted Files Coverage Δ
src/cr/cube/matrix/assembler.py 100.00% <100.00%> (ø)
src/cr/cube/matrix/measure.py 100.00% <100.00%> (ø)
src/cr/cube/matrix/subtotals.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4705ad8...6bb215f. Read the comment docs.

@ernestoarbitrio ernestoarbitrio merged commit 433ee46 into master Apr 21, 2021
@ernestoarbitrio ernestoarbitrio deleted the refactor-sig-letters-means-177824342 branch April 21, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants