Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop size cat dates 177831399 #284

Merged
merged 4 commits into from
Apr 27, 2021
Merged

Conversation

slobodan-ilic
Copy link
Contributor

No description provided.

@ernestoarbitrio ernestoarbitrio self-requested a review April 20, 2021 12:56
Copy link
Contributor

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per comments

src/cr/cube/cubepart.py Outdated Show resolved Hide resolved
src/cr/cube/cubepart.py Show resolved Hide resolved
src/cr/cube/dimension.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #284 (88d4826) into master (fa43633) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 88d4826 differs from pull request most recent head a25a24e. Consider uploading reports for the commit a25a24e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          20       20           
  Lines        4146     4160   +14     
=======================================
+ Hits         4145     4159   +14     
  Misses          1        1           
Impacted Files Coverage Δ
src/cr/cube/cubepart.py 100.00% <100.00%> (ø)
src/cr/cube/dimension.py 100.00% <100.00%> (ø)
src/cr/cube/enums.py 100.00% <100.00%> (ø)
src/cr/cube/matrix/measure.py 100.00% <0.00%> (ø)
src/cr/cube/matrix/cubemeasure.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa43633...a25a24e. Read the comment docs.

@Crunch-io Crunch-io deleted a comment from coveralls Apr 20, 2021
Copy link
Contributor

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per comments

src/cr/cube/dimension.py Show resolved Hide resolved
src/cr/cube/cubepart.py Outdated Show resolved Hide resolved
@slobodan-ilic slobodan-ilic force-pushed the pop-size-cat-dates-177831399 branch 3 times, most recently from db58521 to 9775859 Compare April 22, 2021 09:32
Copy link
Contributor

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but i'd like to be sure that the population_counts_moe for strand is correct (0) in case of CAT_DATE dimension.

@slobodan-ilic slobodan-ilic force-pushed the pop-size-cat-dates-177831399 branch 2 times, most recently from 88d4826 to 02a86e8 Compare April 23, 2021 16:33
* Drive by unit tests in the `test_dimension.py` module
* Resolve dimension type to categorical date, if it has all properties
  of a "normal" categorical dimension, plus a `"date"` field in any of
  its categories.
* Add tests that demonstrate the correct expectations for the population
  counts and margins of error, in case when there are categorical dates
  involved as one of the dimensions
* Add the required fixtures to demonstrate the correct values in the
  tests
* According to the categorical date dimension, decide which property to
  use to multiply the given population
* Apply these fixes to both 2D and 1D cube partitions
* Add a docstring to a new property
* Reuse more sophisticated properties in the implementation
@slobodan-ilic slobodan-ilic merged commit 27cfd8d into master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants