-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pop size cat dates 177831399 #284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per comments
e0646b2
to
d96bdc9
Compare
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 20 20
Lines 4146 4160 +14
=======================================
+ Hits 4145 4159 +14
Misses 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per comments
db58521
to
9775859
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but i'd like to be sure that the population_counts_moe
for strand is correct (0) in case of CAT_DATE dimension.
88d4826
to
02a86e8
Compare
* Drive by unit tests in the `test_dimension.py` module * Resolve dimension type to categorical date, if it has all properties of a "normal" categorical dimension, plus a `"date"` field in any of its categories.
* Add tests that demonstrate the correct expectations for the population counts and margins of error, in case when there are categorical dates involved as one of the dimensions * Add the required fixtures to demonstrate the correct values in the tests
* According to the categorical date dimension, decide which property to use to multiply the given population * Apply these fixes to both 2D and 1D cube partitions
* Add a docstring to a new property * Reuse more sophisticated properties in the implementation
02a86e8
to
a25a24e
Compare
No description provided.