Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/tweak field names #1002

Merged
merged 14 commits into from
Jun 7, 2021
Merged

Improvement/tweak field names #1002

merged 14 commits into from
Jun 7, 2021

Conversation

redroy44
Copy link
Contributor

@redroy44 redroy44 commented May 17, 2021 •
edited
Loading

This PR introduces:

Bitcoin:

  • remove time field from transactions (was duplicated with block_time)
  • change height and block_height fields to level and block_level respectively
  • change blockhash field to block_hash

Ethereum:

  • change number and block_number fields to level and block_level respectively

@redroy44 redroy44 mentioned this pull request May 18, 2021
Merged
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
11.7% 11.7% Duplication

@vishakh vishakh merged commit d63998f into master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonymoussprocket anonymoussprocket anonymoussprocket approved these changes

@piotrkosecki piotrkosecki piotrkosecki approved these changes

@vishakh vishakh Awaiting requested review from vishakh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@redroy44 @piotrkosecki @anonymoussprocket @vishakh