Feature/tzip 16 #1014
Merged
Feature/tzip 16 #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # sql/conseil.sql
vishakh
requested changes
Jul 16, 2021
sql/conseil.sql
Outdated
| address text NOT NULL, | ||
| raw_metadata text NOT NULL, | ||
| name text NOT NULL, | ||
| desctiption text, |
vishakh
requested changes
Jul 27, 2021
| import scala.concurrent.{ExecutionContext, Future} | ||
| import scala.util.Try | ||
|
|
||
| class MetadataProcessor( |
There was a problem hiding this comment.
A comment explaining the purpose of this class and how it works would be very useful here.
|
|
||
| object Tzip16 { | ||
|
|
||
| private def proceduralDecode(hex: String): String = { |
There was a problem hiding this comment.
Please leave a note about the function here.
| fetch[(Tables.RegisteredTokensRow, Tables.BigMapContentsRow, String), Option[(String, Tzip16Metadata)], Future, List, Throwable] | ||
| .run(addresses) | ||
|
|
||
| def getHttpMetadataWithRegisteredTokensRow( |
| val showHashes = hashes.mkString(", ") | ||
| logger | ||
| .error( | ||
| s"I encountered problems while fetching baking rights from TZIP-16 for blocks $showHashes. The error says ${err.getMessage}" |
| case ((ipfs, http), acc) if acc._3.startsWith("ipfs") => (acc :: ipfs, http) | ||
| case ((ipfs, http), acc) if acc._3.startsWith("http") => (ipfs, acc :: http) | ||
| } | ||
| println(metadata) |
|
Kudos, SonarCloud Quality Gate passed!
|
vishakh
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #999
Implemented handling of the tzip-16 metadata fetching as described in the ticket.