-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
887 - Lorre for Ethereum #897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly suggestions and a couple of questions.
The logic is pretty good
conseil-common/src/main/scala/tech/cryptonomic/conseil/common/config/Platforms.scala
Outdated
Show resolved
Hide resolved
conseil-common/src/main/scala/tech/cryptonomic/conseil/common/config/Platforms.scala
Show resolved
Hide resolved
conseil-lorre/src/main/scala/tech/cryptonomic/conseil/indexer/ethereum/EthereumIndexer.scala
Outdated
Show resolved
Hide resolved
conseil-lorre/src/main/scala/tech/cryptonomic/conseil/indexer/ethereum/EthereumIndexer.scala
Outdated
Show resolved
Hide resolved
conseil-lorre/src/main/scala/tech/cryptonomic/conseil/indexer/ethereum/EthereumOperations.scala
Outdated
Show resolved
Hide resolved
conseil-lorre/src/main/scala/tech/cryptonomic/conseil/indexer/ethereum/EthereumOperations.scala
Outdated
Show resolved
Hide resolved
conseil-lorre/src/main/scala/tech/cryptonomic/conseil/indexer/ethereum/EthereumOperations.scala
Show resolved
Hide resolved
conseil-lorre/src/main/scala/tech/cryptonomic/conseil/indexer/ethereum/EthereumOperations.scala
Outdated
Show resolved
Hide resolved
...-lorre/src/test/scala/tech/cryptonomic/conseil/indexer/ethereum/EthereumOperationsTest.scala
Outdated
Show resolved
Hide resolved
...-lorre/src/test/scala/tech/cryptonomic/conseil/indexer/ethereum/EthereumOperationsTest.scala
Outdated
Show resolved
Hide resolved
ec0d4f5
to
475c715
Compare
475c715
to
ed453c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Most of the code is based on existing Bitcoin implementation.