Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

887 - Lorre for Ethereum #897

Merged
merged 10 commits into from
Sep 7, 2020
Merged

887 - Lorre for Ethereum #897

merged 10 commits into from
Sep 7, 2020

Conversation

molowny
Copy link
Contributor

@molowny molowny commented Aug 7, 2020

Most of the code is based on existing Bitcoin implementation.

@molowny molowny added the Eth-Int Ethereum Integration label Aug 7, 2020
Copy link
Contributor

@ivanopagano ivanopagano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly suggestions and a couple of questions.

The logic is pretty good

@molowny molowny force-pushed the feature/887-lorre-for-ethereum branch from ec0d4f5 to 475c715 Compare August 31, 2020 08:47
@molowny molowny changed the base branch from master to feature/887-bytecode-disassembler August 31, 2020 09:39
@molowny molowny force-pushed the feature/887-lorre-for-ethereum branch from 475c715 to ed453c3 Compare September 2, 2020 16:06
@molowny molowny changed the base branch from feature/887-bytecode-disassembler to master September 2, 2020 16:07
@molowny molowny marked this pull request as ready for review September 2, 2020 16:47
Copy link
Contributor

@piotrkosecki piotrkosecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 10 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

@vishakh vishakh merged commit 331abdb into master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Eth-Int Ethereum Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants