Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delphinet to metadata file, and create new conf file for delphi #919

Merged
merged 4 commits into from
Sep 24, 2020
Merged

Add delphinet to metadata file, and create new conf file for delphi #919

merged 4 commits into from
Sep 24, 2020

Conversation

PrathamRawat
Copy link
Contributor

No description provided.

ivanopagano
ivanopagano approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@ivanopagano ivanopagano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

I raised a couple questions out of the review

@piotrkosecki
Copy link
Contributor

one more thing I remembered, please add this line to the Dockerfile below other configs:

ADD ./conseil-api/src/main/resources/metadata/tezos.delphinet.conf /root/tezos.delphinet.conf

@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vishakh vishakh merged commit 2576209 into master Sep 24, 2020
@ivanopagano ivanopagano added the configuration-change-required There are adjustments needed to properly deploy the application after the code is accepted label Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanopagano ivanopagano ivanopagano approved these changes

@leenpaws leenpaws leenpaws approved these changes

@piotrkosecki piotrkosecki piotrkosecki approved these changes

@vishakh vishakh vishakh approved these changes

Assignees
No one assigned
Labels
configuration-change-required There are adjustments needed to properly deploy the application after the code is accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PrathamRawat @piotrkosecki @vishakh @ivanopagano @leenpaws