Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Friendly to end-users #57

Merged
merged 7 commits into from
Sep 12, 2018
Merged

Friendly to end-users #57

merged 7 commits into from
Sep 12, 2018

Conversation

Cryrivers
Copy link
Owner

@Cryrivers Cryrivers commented Sep 5, 2018 •
edited
Loading

image

remove some obstacles for new users.

  • --official-plugins option to list all official plugins
  • Warnings if there's no plugins installed
  • Overhaul Error Reporting and Handling

@codecov
Copy link

codecov bot commented Sep 5, 2018 •
edited
Loading

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          49       49           
  Lines        1068     1068           
  Branches      155      155           
=======================================
  Hits          783      783           
  Misses        276      276           
  Partials        9        9
Impacted Files Coverage Δ
packages/core/runtime/src/types/TupleType.ts 94.73% <0%> (-5.27%) ⬇️
packages/core/runtime/src/types/OptionalType.ts 100% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c208d3...6daa892. Read the comment docs.

@Cryrivers Cryrivers changed the title Add a param to show all official plugins WIP: Add a param to show all official plugins Sep 6, 2018
tanhauhau
tanhauhau previously approved these changes Sep 6, 2018
View reviewed changes
@Cryrivers Cryrivers changed the title WIP: Add a param to show all official plugins WIP: Epic: More friendly to end-users Sep 6, 2018
@Cryrivers Cryrivers changed the title WIP: Epic: More friendly to end-users WIP: Epic: Friendly to end-users Sep 6, 2018
tanhauhau
tanhauhau reviewed Sep 6, 2018
View reviewed changes
Copy link
Collaborator

@tanhauhau tanhauhau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great if we have search feature and choose plugin to install from the table

@Cryrivers Cryrivers mentioned this pull request Sep 7, 2018
Merged
@Cryrivers
Copy link
Owner Author

would be great if we have search feature and choose plugin to install from the table

i'll create an issue for this, but wont fix on this branch.

@Cryrivers Cryrivers mentioned this pull request Sep 12, 2018
Open
@Cryrivers Cryrivers changed the title WIP: Epic: Friendly to end-users Friendly to end-users Sep 12, 2018
@Cryrivers Cryrivers merged commit 87b8f06 into master Sep 12, 2018
@Cryrivers Cryrivers deleted the wangz/plugin-search branch September 12, 2018 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanhauhau tanhauhau tanhauhau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cryrivers @tanhauhau