Net compression #205
Merged
Net compression #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just need to clean the code real quick and this should be ready to merge :) |
Deploying with
|
| Latest commit: |
9cce065
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f6ad96f0.cubic-server.pages.dev |
| Branch Preview URL: | https://net-compression.cubic-server.pages.dev |
|
Ok so it looks like Krypton is incompatible with this implementation of the compression, I have no idea why though :/ |
added 4 commits
September 16, 2023 17:59
Also put online-mode in experimental because of how unstable it is
Just need to change add_buffer_to_vector to merge this
emneo-dev
force-pushed
the
net_compression
branch
from
ef77de9
to
ef30ce9
Compare
This was referenced Sep 16, 2023
STMiki
reviewed
Sep 16, 2023
cubic-server/CompressionUtils.cpp
Outdated
Comment on lines
12
to
13
| char current_character = buffer[character_index]; | ||
| vector.push_back(current_character); |
There was a problem hiding this comment.
?
Suggested change
| char current_character = buffer[character_index]; | |
| vector.push_back(current_character); | |
| vector.push_back(buffer[character_index]); |
cubic-server/CompressionUtils.cpp
Outdated
| unsigned half_length = size / 2; | ||
|
|
||
| unsigned uncompLength = full_length; | ||
| char *uncomp = (char *) calloc(sizeof(char), uncompLength); |
There was a problem hiding this comment.
What is wrong with it?
added 4 commits
September 17, 2023 12:16
It looks like it is the default on many implementations. It needs to be measured if it is the best for us later.
Just use std::vector::insert xd
istg obo are the worst kind of errors there is
|
Fixed #208 , just a freaking off by one error :))))))))) |
Trompettesib
approved these changes
Sep 17, 2023
STMiki
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also made online-mode experimental, because the unstability would just crash directly with the compression.