Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add furnace operation #263

Merged
merged 43 commits into from
Jan 12, 2024
Merged

Add furnace operation #263

merged 43 commits into from
Jan 12, 2024

Conversation

Trompettesib
Copy link
Member

No description provided.

@Trompettesib Trompettesib self-assigned this Dec 28, 2023
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 29, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5a3e03d
Status: ✅  Deploy successful!
Preview URL: https://2e67de1e.cubic-server.pages.dev
Branch Preview URL: https://tile-entity-furnace.cubic-server.pages.dev

View logs

@Trompettesib Trompettesib force-pushed the tile-entity/furnace branch 2 times, most recently from 9ca8f64 to eb51d00 Compare December 29, 2023 22:11
@Trompettesib Trompettesib mentioned this pull request Jan 4, 2024
Closed
@Trompettesib Trompettesib force-pushed the tile-entity/furnace branch 6 times, most recently from a3f2bf4 to 6d9a81a Compare January 7, 2024 18:08
@Trompettesib Trompettesib marked this pull request as ready for review January 7, 2024 21:40
@Trompettesib Trompettesib force-pushed the tile-entity/furnace branch 3 times, most recently from 4d5e49c to 33f4d49 Compare January 7, 2024 22:20
PierrickMarguin
PierrickMarguin previously approved these changes Jan 9, 2024
View reviewed changes
emneo-dev
emneo-dev suggested changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@emneo-dev emneo-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quirks to the function of the furnace but it will be ok.

cubic-server/world_storage/ChunkColumn.hpp Outdated Show resolved Hide resolved
cubic-server/tiles-entities/TileEntityList.hpp Show resolved Hide resolved
cubic-server/tiles-entities/TileEntityList.hpp Outdated Show resolved Hide resolved
cubic-server/protocol/container/Container.hpp Outdated Show resolved Hide resolved
@Trompettesib
Change all unique_ptr for tile entity management into shared_ptr
15beea7
@Trompettesib
Remove warnings by fixing the code
648de5d
@Trompettesib
Fix last using of modulo instead of convertPositionToChunkPosition an…
a577eb7 
…d clean the code
@Trompettesib
Fix windowId type in container
1e57f5a
@Trompettesib
Add set container property packet handling
c64578f
@Trompettesib
Add update of the container properties in the furnace tile entity
fbac1a8
@Trompettesib
Fix index of cariedItem (default was 0 but needed to be -1)
534bbdc
@Trompettesib
Add a coal and some cobblestone to the inventory
6ce4c4c
@Trompettesib
Add a way to update the block of a tile entity
60c0f8d
@Trompettesib
Add a convert function to convert block position relative to chunk po…
1be23ee 
…sition into absolute position
@Trompettesib
Add a getContainer function to get a container from it's id
795b14d
@Trompettesib
Change how sendOpenScreen is sent
9626097
@Trompettesib
Add update of slots in the furnace
bfec362
@Trompettesib
Add a way to get the burning time of a fuel
ddadf0f
@Trompettesib
Change all LINFO to LTRACE
e0cdccd
@Trompettesib
Change all unique_ptr into shared_ptr in recipes
0917a0a
@Trompettesib
Add initialization of recipes in the server
6d71f0e
@Trompettesib
Add a oak_log in the player hotbar at connexion
62e5bea
@Trompettesib
Add some functions to get some recipes
169620f
@Trompettesib
Add some functions to get ingredient, result and cooking time of a sm…
569558d 
…elting recipes
@Trompettesib
Add recipes to the furnace tile entity
1d87836 
Add an enum for the container property
Add the reverse progression of cooking when there is no fuel left and the cooking has started
Add a check to see if the ingredient can be smelted
Fix warnings about unused variables
@Trompettesib
Change enum to enum class and add all the casts needed
2e29053
@Trompettesib
Remove useless array
bc619ba
@Trompettesib
Change the way of storing tile entities in chunkcolumn
8a4e8ba
@Trompettesib
Remove if forest
5a3e03d
PierrickMarguin
PierrickMarguin approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@PierrickMarguin PierrickMarguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@Trompettesib Trompettesib merged commit 5f588db into master Jan 12, 2024
4 checks passed
@Trompettesib Trompettesib deleted the tile-entity/furnace branch January 12, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierrickMarguin PierrickMarguin PierrickMarguin approved these changes

@emneo-dev emneo-dev emneo-dev approved these changes

@STMiki STMiki Awaiting requested review from STMiki

@QuentindiMeo QuentindiMeo Awaiting requested review from QuentindiMeo

Assignees

@Trompettesib Trompettesib

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trompettesib @emneo-dev @PierrickMarguin