Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support deepcopy & copy #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support deepcopy & copy #21

wants to merge 1 commit into from

Conversation

acmol
Copy link

@acmol acmol commented Nov 21, 2017

No description provided.

@acmol acmol changed the title support deepcopy & copy by serialize and deserialize support deepcopy & copy Nov 21, 2017
advancedxy
advancedxy reviewed Apr 9, 2018
View reviewed changes
Copy link

@advancedxy advancedxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except one comment

src/fastpb/template/test.jinjapy
@@ -54,6 +56,15 @@ class Test_{{ file.package.replace('.', '_') }}(unittest.TestCase):
{% for field in message.field %}
self.assertEquals(pb.{{ field.name }}, pb2.{{ field.name }})
{% endfor %}

pb3 = copy.deepcopy(pb)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add a copy.copy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@advancedxy advancedxy advancedxy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acmol @advancedxy