Remove custom font #182
Merged
Remove custom font #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2020 02:27
As explained in #179, the custom font is unnecessary for our situation and removing it could help improving page load significantly. Note that removing our option means that the default font choice of Bootstrap will be used. Since we are on version 4, it will be a [native font stack](https://getbootstrap.com/docs/4.5/content/reboot/#native-font-stack) which I think is really good for our case because there would be no loading or fetching at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #179, the custom font is unnecessary for our situation and removing it could help improving page load significantly.
Note that removing our option means that the default font choice of Bootstrap will be used. Since we are on version 4, it will be a native font stack which I think is really good for our case because there would be no loading or fetching at all.