Resolved MainSaveFile Singleton anti-pattern and added Turnip prices #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuyler36
reviewed
Apr 12, 2020
MyHorizons/Data/Save/MainSaveFile.cs
Outdated
| public int NumPlayers => _playerSaves.Count; | ||
| public readonly Town? Town; | ||
| public readonly Turnips? Turnips; |
There was a problem hiding this comment.
Ideally this should be in the Town class as the idea is for it to encompass everything town related and turnip prices are per-town.
|
Also I'm not a fan of the name "Turnips". Preferably the name should convey purpose. You aren't editing the turnips but rather the selling/buy price. I'd prefer something more like "StalkMarket". |
moved StalkMarket Property to the Town class
|
Funny thing, I was also thinking about it, after I created the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added Turnip prices to MyHorizons.
While I was working with the code I couldn't overlook the MainSaveFile.Singleton().
It isn't a real Singletone and it can be solved without it, I hope you don't mind my refactoring.