Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waifu2x-ncnn-vulkan #20

Merged
merged 16 commits into from
May 29, 2020
Merged

Add waifu2x-ncnn-vulkan #20

merged 16 commits into from
May 29, 2020

Conversation

CyFeng16
Copy link
Owner

@CyFeng16 CyFeng16 commented May 27, 2020

Since PR #15 is still in draft state, I pulled the PR then established this new branch. Daniel made huge progress that added the waifu2x function to our repository, I just can not wait to complete some follow-up documentation work.
@EtianAM PHAL.

@CyFeng16
Copy link
Owner Author

@EtianAM Some conflicts were solved and this PR is ready. Maybe you can give it a go.

@re2cc
Copy link
Contributor

re2cc commented May 27, 2020

Thanks for completing it, I've been a little busy and I couldn't make any progress. I think there's a missing argument, I didn't see it until yesterday, I think it's -x or something like that, I'm not sure, you can see the original arguments with ./waifu2x-ncnn-vulkan in the build folder.
Also missing the extension support (Only supports png)

@CyFeng16
Copy link
Owner Author

I will try to do something about the missing argument as well as the png output format. Maybe just after a little rest and then I can do the job. What's a pity, rocket didn't launch today (T_T)

@CyFeng16
Copy link
Owner Author

CyFeng16 commented May 28, 2020

@EtianAM I found -x for TTA mode and will get it done. The original output format is limited to png so that I will obey the rule.
Done!

@CyFeng16 CyFeng16 added the enhancement New feature or request label May 28, 2020
@re2cc
Copy link
Contributor

re2cc commented May 28, 2020

@EtianAM I found -x for TTA mode and will get it done. The original output format is limited to png so that I will obey the rule.
Done!

Thank you for adding the argument. Hmm... I could swear I've ever given you a jpg input, maybe later I'll check

@CyFeng16
Copy link
Owner Author

@EtianAM Maybe I misunderstand that. Currently, we input a jpg/png, and then the program outputs a png image.

@re2cc
Copy link
Contributor

re2cc commented May 29, 2020

@EtianAM Maybe I misunderstand that. Currently, we input a jpg/png, and then the program outputs a png image.

No, I think I should have tried that before I spoke, sorry. Well, I do not see any problems anymore, if I had to give some, it would be that it does not detect errors, that is, if something fails, the script does not warn.
Also that the README of waifu2x-vulkan, has no images, but it is not a big problem, I think that the above could be a little bigger, but neither is something vital.

Thank you for your work.

@CyFeng16
Copy link
Owner Author

We do have a image for description (speeded up through cdn ), which will be seen after merge. We could add some assert judgments if really necessary in another PR.

@CyFeng16 CyFeng16 merged commit 4688e2b into master May 29, 2020
@CyFeng16 CyFeng16 deleted the waifu2x-ncnn-vulkan branch May 31, 2020 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants