-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add waifu2x-ncnn-vulkan #20
Conversation
Add waifu2x-ncnn-vulkan repositoy and submodules
Add a preliminary preparation to build and make it work.
I put _ when was -
I put models_dir in place of build_dir
Delete unused images from waifu2x-ncnn-vulkan and its dir
Add inference file for waifu2x-vulkan run
@EtianAM Some conflicts were solved and this PR is ready. Maybe you can give it a go. |
Thanks for completing it, I've been a little busy and I couldn't make any progress. I think there's a missing argument, I didn't see it until yesterday, I think it's -x or something like that, I'm not sure, you can see the original arguments with ./waifu2x-ncnn-vulkan in the build folder. |
I will try to do something about the missing argument as well as the png output format. Maybe just after a little rest and then I can do the job. What's a pity, rocket didn't launch today (T_T) |
@EtianAM I found |
Thank you for adding the argument. Hmm... I could swear I've ever given you a jpg input, maybe later I'll check |
@EtianAM Maybe I misunderstand that. Currently, we input a jpg/png, and then the program outputs a png image. |
No, I think I should have tried that before I spoke, sorry. Well, I do not see any problems anymore, if I had to give some, it would be that it does not detect errors, that is, if something fails, the script does not warn. Thank you for your work. |
We do have a image for description (speeded up through cdn ), which will be seen after merge. We could add some assert judgments if really necessary in another PR. |
Since PR #15 is still in draft state, I pulled the PR then established this new branch. Daniel made huge progress that added the waifu2x function to our repository, I just can not wait to complete some follow-up documentation work.
@EtianAM PHAL.