Fix issue with XXHASH_BUILD_XXHSUM cmake setting #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `set(... CACHE ...)` causes `XXHASH_BUILD_XXHSUM` to be stuck `ON` even when doing a `set(XXHASH_BUILD_XXHSUM OFF)` for some cmake version/generators. Switching to `option(...)` fixes this issue and allows you to properly turn off the building of xxhsum in all situations.
Cyan4973
approved these changes
Oct 26, 2020
|
Thanks @Cyan4973 for the quick review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
set(... CACHE ...)causesXXHASH_BUILD_XXHSUMto be stuckONeven when doing aset(XXHASH_BUILD_XXHSUM OFF)for some cmake version/generators. Switching tooption(...)fixes this issue and allows you to properly turn off the building of xxhsum in all situations.Currently using
set(XXHASH_BUILD_XXHSUM OFF CACHE BOOL "" FORCE)before including xxhash into another cmake project gets around the issue but is non-obvious.