Avoid eventloop restart if listen_address or port didn't changed #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
CyberDem0n
commented
Nov 13, 2017
CyberDem0n
commented
- use event_base_loopexit function to stop eventloop instead of pthread_cancel
use event_base_loopexit function to stop eventloop instead of pthread_cancel
a1exsh
reviewed
Nov 13, 2017
bg_mon.c
Outdated
|
|
||
| restart: | ||
| strcpy(bg_mon_listen_address, bg_mon_listen_address_guc); |
a1exsh
reviewed
Nov 13, 2017
bg_mon.c
Outdated
| @@ -270,6 +270,13 @@ bg_mon_main(Datum main_arg) | |||
| evthread_use_pthreads(); | |||
|
|
|||
| restart: | |||
| bg_mon_listen_address = repalloc(bg_mon_listen_address, | |||
There was a problem hiding this comment.
Don't you want to pfree the old value before rewriting it?
CyberDem0n
added a commit
that referenced
this pull request
Nov 13, 2017
use event_base_loopexit function to stop eventloop instead of pthread_cancel
CyberDem0n
added a commit
that referenced
this pull request
Nov 13, 2017
use event_base_loopexit function to stop eventloop instead of pthread_cancel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.