Read PSI information #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erthalion
force-pushed
the
feature/psi
branch
2 times, most recently
from
0ed31ed
to
9b6448f
Compare
CyberDem0n
reviewed
Feb 8, 2021
Comment on lines
+110
to
+112
| if (strncmp(type, "full", 4) == 0) | ||
| p.type = FULL; | ||
|
|
There was a problem hiding this comment.
What if we get "full" from the "cpu" (e.g. new kernel)?
There was a problem hiding this comment.
From what I understand it should not be the case even for new kernels (the latest says only "the format for CPU ..." with no mentioning it being changed one day). But if needed it could be easily addressed by extending p_cpu array to two elements.
Use two element array for cpu as well for consistensy.
CyberDem0n
pushed a commit
that referenced
this pull request
Feb 9, 2021
Should be the case starting from Linux Kernel 4.20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read and display Pressure Stall Information if available (which should be the case starting from Linux Kernel 4.20).