This repository has been archived by the owner on Sep 29, 2022. It is now read-only.
Add new error messages and rescuing #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fakenine
force-pushed
the
add_error_messages
branch
from
00eca15
to
b87f3c0
Compare
fwininger
reviewed
Mar 10, 2018
| @@ -8,8 +8,8 @@ class InvalidLogin < StandardError; end | |||
|
|
|||
| # Do Login | |||
| def self.login | |||
| raise InvalidLogin, 'Please configure the username' unless Openvas::Config.username | |||
| raise InvalidLogin, 'Please configure the password' unless Openvas::Config.password | |||
| raise ConfigError, 'Username not configured' unless Openvas::Config.username | |||
There was a problem hiding this comment.
You should remove the class InvalidLogin
lib/openvas/client.rb
Outdated
| socket.connect | ||
| rescue Errno::ECONNREFUSED, OpenSSL::SSL::SSLError, SocketError, | ||
| URI::InvalidURIErro => e | ||
| raise ConfigError, e |
There was a problem hiding this comment.
You should raise something like a ConnectionError
lib/openvas/client.rb
Outdated
| socket.close | ||
| self.socket = nil | ||
| rescue SocketError => e | ||
| raise ConfigError, e |
There was a problem hiding this comment.
You should raise something like a ConnectionError
fakenine
force-pushed
the
add_error_messages
branch
from
b87f3c0
to
8539bad
Compare
fwininger
approved these changes
Mar 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new error messages and rescuing to better contextualize and understand errors when using the client.