Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio io pins could live at the top of the node by default #25

Closed
jinpavg opened this issue Nov 6, 2023 · 4 comments
Closed

audio io pins could live at the top of the node by default #25

jinpavg opened this issue Nov 6, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@jinpavg
Copy link
Contributor

jinpavg commented Nov 6, 2023

could be slightly more ergonomic for patching in the MS graph

@jinpavg jinpavg added the enhancement New feature or request label Nov 6, 2023
@x37v x37v self-assigned this Dec 14, 2023
@x37v
Copy link
Contributor

x37v commented Dec 14, 2023

@jinpavg what do you think is a good order, we have:

  • audio
  • float
  • bool
  • int (to be enum)
  • wave asset
  • trigger
  • midi
  • transport

should the order be the same for input and output?

@jinpavg
Copy link
Contributor Author

jinpavg commented Dec 14, 2023

So -- what if we have a default order, but then also the ability to define pin sort order with meta ? The MS graph variables and inputs have this notion of "sort order" where higher numbers are sorted further down the node.

So you could say like

inport foo @meta sortorder: -1
param bar @meta sortorder: 10

but our default order could prioritize audio input/output, like, this is fairly arbitrary, but maybe:

  • audio
  • midi
  • trigger
  • bool
  • float
  • enum
  • wave
  • transport

the rationale here being audio could flow across the top of the node, the transport sort of makes sense to patch in at the bottom, the enum and wave dropdowns can be at the bottom so they don't block text when the disclosure menu opens.

@jinpavg
Copy link
Contributor Author

jinpavg commented Dec 14, 2023

i guess the only thing is you couldn't define sort order on MIDI, Transport, and Wave (since buffer~ doesn't have @meta)

x37v added a commit that referenced this issue Dec 15, 2023
@x37v
Copy link
Contributor

x37v commented Dec 15, 2023

updated on develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants