-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding directories starting with __ to ignore #1004
Conversation
analyzer.js
Outdated
@@ -27,6 +27,7 @@ const IGNORE_DIRS = process.env.ASTGEN_IGNORE_DIRS | |||
"flow-typed", | |||
"i18n", | |||
"__tests__", | |||
"__mocks__", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need both now that we are checking for double underscore below? Can we remove line 29 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need both now that we are checking for double underscore below? Can we remove line 29 as well?
I think yes, we can remove them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@almaz045 could you run |
npm run lint > @cyclonedx/cdxgen@10.4.2 lint > biome check --apply-unsafe * sh: 1: biome: not found |
@almaz045 Can you remove node_modules and perform a fresh npm install? |
yes. should I create new PR ? |
Signed-off-by: almaz045 <internet69s@mail.ru>
@almaz045 same PR is ok. biome should get installed automatically with a fresh npm install. Not sure why it is not getting found. |
it seems good now |
I came across a Node component that was located in the "mocks" folder, but was still specified as scope: "required". It turned out that there is no ignoring in cdxgen for a similar directory. This directory has been added