-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update snapshot tests to integrate new custom-json-diff functionality. #1157
Conversation
1ad1c41
to
4bbfc3b
Compare
@cerrussell, Impressive work!
I think the cyclonedx maven plugin currently over-reports required dependencies. I noticed this while trying the new maven deps tree approach using the environment variable |
@prabhu I don't have |
@cerrussell any updates? Did you get a chance to test the last two versions of the cyclonedx maven plugin directly? |
@prabhu I ran the maven plugin directly and got the same thing. However, I did a bit of digging and I think what's actually happened is the devs at netty thought they had made these dependencies optional but because of the way one of their plugins worked, they were mandatory. This commit (Remove unwanted mandatory dependency in OSGi) details what happened and it makes sense why cyclonedx maven plugin changed what were intended to be optional dependencies to required... it is actually correct. I'm therefore going to update the netty bom and then we should be good to go. |
8ead49a
to
aee020a
Compare
Signed-off-by: Caroline Russell <caroline@appthreat.dev>
Signed-off-by: Caroline Russell <caroline@appthreat.dev> Troubleshoot pnpm issue. Signed-off-by: Caroline Russell <caroline@appthreat.dev>
Signed-off-by: Caroline Russell <caroline@appthreat.dev>
3d98b1d
to
0a76b01
Compare
Signed-off-by: Caroline Russell <caroline@appthreat.dev>
403380a
to
df39dcf
Compare
Changes
Notes on the current configuration of the tests
@prabhu @setchy I have tested with the snapshots, updated the ones which required updating (properties expanded for a couple) and there's one thing I need to check on.
Change of scope from optional to required for bouncy castles dependencies for netty. The netty pom indicates these are optional. Thoughts?
Closes #1112